api: create new endpoint for access/users #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikachurilova
force-pushed
the
rework-access-users-endpoint
branch
from
52df833
to
967d7b6
Compare
0einstein0
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Reviewed with @jrcastro2. Left a few comments. LGTU
Thank you for extensive tests 🚀
anikachurilova
force-pushed
the
rework-access-users-endpoint
branch
from
967d7b6
to
ce5b6c4
Compare
anikachurilova
force-pushed
the
rework-access-users-endpoint
branch
5 times, most recently
from
d741bf5
to
1a2e551
Compare
anikachurilova
commented
Feb 26, 2024
anikachurilova
commented
Feb 26, 2024
ptamarit
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Thanks a lot!
Apart from the review with @ptamarit, here are some comments:
- Naming consistency: I see we have
RDMGrantsAccessResource,RDMGrantUserAccessResource(see the pluralgrants) - The records service is growing a lot, would it make sense to split these new
*_grant_by_subjectmethod calls? access grants usersandaccess grantslive in the same service since they are similar (related to record access), however, they seem to be different now in terms of functionality.
We can also chat IRL so I can get better context about the change.
anikachurilova
force-pushed
the
rework-access-users-endpoint
branch
3 times, most recently
from
8abd3ae
to
2764dd7
Compare
ntarocco
approved these changes
Mar 15, 2024
anikachurilova
force-pushed
the
rework-access-users-endpoint
branch
from
2764dd7
to
d0b85b6
Compare
kpsherva
reviewed
Mar 15, 2024
kpsherva
reviewed
Mar 15, 2024
ntarocco
approved these changes
Apr 3, 2024
anikachurilova
force-pushed
the
rework-access-users-endpoint
branch
from
d0b85b6
to
aada311
Compare
zzacharo
reviewed
Apr 3, 2024
anikachurilova
force-pushed
the
rework-access-users-endpoint
branch
2 times, most recently
from
2006032
to
1073274
Compare
* add resource and service layer * add error handerls * add links * cover with tests * closes inveniosoftware#1671
anikachurilova
force-pushed
the
rework-access-users-endpoint
branch
from
d53fed3
to
a9e065b
Compare
zzacharo
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
access/usersendpoint #1671