Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 publication date edtf lvl0 #79

Merged

Conversation

fenekku
Copy link
Contributor

@fenekku fenekku commented Mar 18, 2020

closes #23

@fenekku fenekku force-pushed the 23_publication_date_edtf_lvl0 branch from 6bc769e to 353d4f3 Compare March 19, 2020 15:15
invenio_rdm_records/ext.py Outdated Show resolved Hide resolved
invenio_rdm_records/marshmallow/fields.py Outdated Show resolved Hide resolved
invenio_rdm_records/marshmallow/fields.py Outdated Show resolved Hide resolved
invenio_rdm_records/ext.py Outdated Show resolved Hide resolved
- Provide publication_date if missing
- Load _publication_date_search at schema level
- Refactor record fixtures into pre-load and after-load fixtures
- Expand lvl to level
- remove print
@fenekku
Copy link
Contributor Author

fenekku commented Mar 19, 2020

Thanks @lnielsen and @zzacharo for the schema comments: it turned out to be much more work than I thought, but it caught some hidden bugs! You can re-review now.

@fenekku fenekku requested a review from lnielsen March 19, 2020 19:59
@lnielsen lnielsen merged commit 9b302d5 into inveniosoftware:master Mar 20, 2020
@fenekku fenekku deleted the 23_publication_date_edtf_lvl0 branch March 20, 2020 12:36
@fenekku fenekku mentioned this pull request May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publication_date: support for EDTF lvl 0
3 participants