api: added preference param to eliminate ES bouncing issue #107
Conversation
invenio_search/api.py
Outdated
| address = request.headers.get('X-Forwarded-For', request.remote_addr) | ||
| if address is not None: | ||
| # An 'X-Forwarded-For' header includes a comma separated list of | ||
| # the |
There was a problem hiding this comment.
Isn't the comment cut in a strange way?
|
@ntarocco finally you cannot solve inside the init method? Do you need to spread the pain? |
ntarocco
force-pushed
the
added_preference_param
branch
2 times, most recently
from
1c5b6d3
to
9cdee79
Compare
|
@nharraud fixed thanks! |
|
@jbenito3 and for any other reviewer. The only way I found (and deeply discusses with @nharraud) was to expose a factory instead of the class to add this |
| alg = hashlib.md5() | ||
| alg.update(user_hash.encode('utf8')) | ||
| return alg.hexdigest() | ||
| return None |
There was a problem hiding this comment.
IMHO we don't need return None is None by default :)
There was a problem hiding this comment.
Saying it explicitly makes the code more readable. Otherwise it might look like a forgotten return.
ntarocco
force-pushed
the
added_preference_param
branch
from
9cdee79
to
b494e7e
Compare
|
@switowski thanks, I was fixing it, now it should work! |
invenio_search/api.py
Outdated
|
|
||
| Taken from Flask Login utils.py. | ||
| """ | ||
| address = request.headers.get('X-Forwarded-For', request.remote_addr) |
There was a problem hiding this comment.
You can just use request.remote_addr, since we expect that to be set correctly. In case of proxies, you need to use Werkzeug's WSGIProxyFix to set it correctly from X-Forwarded-For headers. In order to correctly determine the right user IP address, you need to know how many proxies are in-front of your webapp. For Invenio this is usually 2: Nginx + HAProxy, hence, making the users' IP appear as second in the list. :-)
ntarocco
force-pushed
the
added_preference_param
branch
from
b494e7e
to
d61bc5a
Compare
|
@lnielsen I have fixed it as you proposed! Thanks for checking! |
* added a method to RecordsSearch to return a new instance of Search with a new query param preference. The value of the param will not change for requests coming from the same user. * closes inveniosoftware#106
ntarocco
force-pushed
the
added_preference_param
branch
from
d61bc5a
to
c618a7a
Compare
added a method to RecordsSearch to return a new instance of Search
with a new query param preference. The value of the param will not
change for requests coming from the same user.
closes search: should do the right thing to prevent bouncing results #106