All vocabularies endpoint and Admin interface #310

karkraeg · 2024-05-14T09:09:59Z

❤️ Thank you for your contribution!

Description

Adresses #307

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

I'm aware of the code of conduct.
I've created logical separate commits and followed the commit message format.
I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
I've NOT included third-party code (copy/pasted source code or new dependencies).
- If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

I've followed the CSS/JS and React guidelines.
I've followed the web accessibility guidelines.
I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

You license your contribution under the same terms as the current repository’s license.
You agree that you have the right to license your contribution under the current repository’s license.

slint

Looks good, some nits and minor comments (and possibly non-important things we shelve in issues).

invenio_vocabularies/administration/__init__.py

invenio_vocabularies/administration/views/vocabularies.py

invenio_vocabularies/config.py

invenio_vocabularies/resources/config.py

invenio_vocabularies/services/service.py

karkraeg · 2024-05-23T08:02:00Z

depends on inveniosoftware/invenio-administration#208

SarahW91 · 2024-06-17T11:49:41Z

I added Uni Münster in the copyright header in the files where we added larger changes. Hope that's okay, otherwise I can remove it again.

slint

Thanks a lot for the clean-up and splitting up the resource and service configs. I think this is looking good and most of my comments are about naming or removing duplicated or redundant config vars and attributes.

I know it's a lot of comments, so if you prefer we could also organize a quick call and go through some of the heavier ones together.

invenio_vocabularies/ext.py

invenio_vocabularies/resources/__init__.py

invenio_vocabularies/resources/resource.py

invenio_vocabularies/services/config.py

invenio_vocabularies/services/service.py

Co-authored-by: mkloeppe <mkloeppe@users.noreply.github.com>

…ries

… working properly.

…nd results in different files and cleaned up code.

…ate button.

…esAdminResource

…minResource

invenio_vocabularies/services/config.py

📁 invenio-administration (2.4.0 -> 2.4.1 ��) 📦 release: v2.4.1 global: remove dependency on invenio-vocabularies * Removes the dependency from invenio-vocabularies. * Delegates administration UI schema type definition to the mashmallow class. 📁 invenio-app-rdm (13.0.0b0.dev6 -> 13.0.0b0.dev8 ) 📦 release: v13.0.0b0.dev8 previewer: gracefuly handle default preference 📦 release: v13.0.0b0.dev7 datastreams: add affiliations and update funders 📁 invenio-banners (3.0.1 -> 3.0.2 🐛) release: v3.0.2 errors: fix validation errors not propagated to resource administration: set default category to info * Fixes inveniosoftware/invenio-banners#26 by setting default category value, which is a required field. 📁 invenio-rdm-records (11.3.1 -> 11.4.0 🌈) 📦 release: v11.4.0 affiliations: update defaults to ror v2 📁 invenio-rest (1.3.0 -> 1.3.1 🐛) release: v1.3.1 tests; fix csrf tests csrf: improve validation * inveniosoftware/invenio-rest#132 📁 invenio-vocabularies (4.0.0 -> 4.1.1 🌈) 📦 release: v4.1.1 installation: use invenio-oaipmh-scythe from PyPI 📦 release: v4.1.0 readers: make OAI-PMH an optional extra schema: add administration UI attributes ror: fix duplicate acronymns and aliases affiliations: fix title search datastreams: have yaml writer output utf8 datastreams: add configs for funders and affiliations affiliations: add datastreams datastreams: move ror transformer to common affiliations: add new fields vocabulary-types: services, resources, and administration UI (inveniosoftware/invenio-vocabularies#310) config: add OpenAIRE mapping for "Latvian Council of Science" tasks: fixed exception logging funding: update award label funders: fix country name display (inveniosoftware/invenio-vocabularies#343) first implementation of OAIPMHReader (inveniosoftware/invenio-vocabularies#329) * first implementation of OAIPMHReader * introduce a simple way to map OAI records to a dict without expecting a special metadata format. * fix installation requirements * fix tests * small fixes to make the tests run * add error handling * renamed oaipmh_scythe package * handle remarks/questions from review. * replaced access to a real OAI server with a mocking implementation. * Update invenio_vocabularies/datastreams/readers.py * Update tests/datastreams/test_datastreams.py * Moved reader tests to testreaders.py * add missing copyright in header --------- global: add "tags" field to all vocabularies

karkraeg linked an issue May 14, 2024 that may be closed by this pull request

Admin panel to list all vocabularies #307

Closed

karkraeg marked this pull request as draft May 14, 2024 11:03

karkraeg linked an issue May 17, 2024 that may be closed by this pull request

New API endpoint which returns a list of all vocabularies #306

Closed

karkraeg marked this pull request as ready for review May 17, 2024 09:21

karkraeg requested a review from slint May 17, 2024 09:22

slint approved these changes May 23, 2024

View reviewed changes

karkraeg mentioned this pull request May 24, 2024

accept kwargs to be passed to get_api_endpoint inveniosoftware/invenio-administration#209

Merged

10 tasks

SarahW91 force-pushed the all_vocabularies_endpoint branch from b782db9 to a5e1f90 Compare June 13, 2024 08:11

SarahW91 mentioned this pull request Jun 17, 2024

Finish vocabularies list admin view #313

Closed

SarahW91 linked an issue Jun 17, 2024 that may be closed by this pull request

Finish vocabularies list admin view #313

Closed

slint approved these changes Jun 19, 2024

View reviewed changes

karkraeg and others added 17 commits June 25, 2024 11:44

register new route

37b5401

Implemented first Admin view based on mock API

e75df2d

Co-authored-by: mkloeppe <mkloeppe@users.noreply.github.com>

add copyright

ee02370

remove WIP import

b5b3a28

remove more imports

9608045

provide API endpoint with aggregated counts for all types of vocabula…

ec5f278

…ries

add missing invenio-administration dependency

2935b1a

Add and update docstrings

f9e7eae

dirty commit, added resources

9853d63

fix imports and cleanup

5c6a166

cleanup

bf655be

overwrite api endpoint

4fe5dd3

Fixes after review. Take out additional list view for now until it is…

7c96f6c

… working properly.

Fixed formatting and doc strings.

5bc8d9d

Fixed formatting

1acc37f

vocabulary types: Implement query functionality

b7f83d2

vocabulary types: Show count in list view

e2065d6

SarahW91 and others added 8 commits June 25, 2024 11:44

vocabulary types: Implement sorting

365c00d

vocabulary type endpoint: fix formatting

cc8d455

vocabulary types endpoint: split implementation for service, config a…

474b4e8

…nd results in different files and cleaned up code.

services: fix service proxy

25c9810

vocabulary types administration: Fix sidebar menu name and remove cre…

2b9802c

…ate button.

vocabulary types administration: Add Uni Münster copyright notice.

7ea3d9a

vocabulary types administration tests: Use correct service for tests

9d66db2

vocabulary types: cleanup

e6ff95a

SarahW91 force-pushed the all_vocabularies_endpoint branch from 842f5c3 to e6ff95a Compare June 25, 2024 09:44

SarahW91 added 3 commits June 25, 2024 17:45

vocabulary types: remove schema property from VocabularyTypeService

329f03f

vocabulary types: remove unused read response handler from Vocabulari…

b5c5ae9

…esAdminResource

vocabulary types: rename route and response handler of VocabulariesAd…

2a2885e

…minResource

SarahW91 mentioned this pull request Jun 26, 2024

Vocabulary item view #347

Open

6 tasks

Samk13 reviewed Jul 4, 2024

View reviewed changes

invenio_vocabularies/services/config.py Show resolved Hide resolved

slint merged commit 810583f into inveniosoftware:master Jul 10, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

All vocabularies endpoint and Admin interface #310

All vocabularies endpoint and Admin interface #310

karkraeg commented May 14, 2024

slint left a comment

karkraeg commented May 23, 2024

SarahW91 commented Jun 17, 2024

slint left a comment

All vocabularies endpoint and Admin interface #310

All vocabularies endpoint and Admin interface #310

Conversation

karkraeg commented May 14, 2024

Description

Checklist

slint left a comment

Choose a reason for hiding this comment

karkraeg commented May 23, 2024

SarahW91 commented Jun 17, 2024

slint left a comment

Choose a reason for hiding this comment