Support environment vars in springboot chart cronjobs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation has been 'stolen' from the respective part of springboot/templates/deployment.yaml So env specification is exactly the same as in deployment
KarolisL
reviewed
Feb 24, 2021
| secretKeyRef: | ||
| {{ toYaml $envdef.secretKeyRef | indent 20 }} | ||
| {{- else }} | ||
| value: {{ required (printf "Value for variable cronJobs.%s.env.%s.value is undefined" $name $envname) $envdef.value | quote }} |
There was a problem hiding this comment.
Suggestion: pipe $envdef.value through template function in order to be flexible and support {{ .Values.sth }} expressions inside values.yaml. Same goes for deployment's env definition
There was a problem hiding this comment.
Make sense. Will do for both deployments & cronjobs in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation has been 'stolen' from the respective part of
springboot/templates/deployment.yaml So env specification is exactly the
same as in deployment