Batch code generation #7000
Merged
Batch code generation #7000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Provide additional kwargs to plugin - Move into new file - Error handling
- Build up a dataset and query server whenever it changes - Look for result in response data - For now, just used for generating batch codes - may be used for more in the future
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SchrodingersGat
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7000 +/- ##
========================================
Coverage 84.03% 84.03%
========================================
Files 1054 1056 +2
Lines 46297 46443 +146
Branches 1326 1334 +8
========================================
+ Hits 38905 39030 +125
- Misses 7063 7077 +14
- Partials 329 336 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matmair
approved these changes
Apr 11, 2024
Co-authored-by: Lukas <76838159+wolflu05@users.noreply.github.com>
…venTree into batch-code-generation
|
Bumping this to the next release cycle, still some work to do here. |
- Move to /generate/ API endpoint - Move batch code generator too
This was referenced May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a solution for #6098, namely allowing batch codes to be generated via a
POSTrequest to an API endpoint.Any data provided to the request is made available to plugins, so a custom plugin could theoretically use this information for the purpose of batch code generation.
This also provides a solution for #6364 (at least in the new react interface), by adding a new
useGeneratorhook function that makes use of this new API endpoint.Related Issues
Tasks
Further Work
Further work could extend on this by:
generators for serial numbers and internal part numbers would hook into existing plugins, allowing these plugins to seamlessly inject data into the front-end forms dynamically