Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce uv into CI actions #7309

Closed
wants to merge 7 commits into from

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat added CI CI / unit testing ecosystem dependency Relates to a project dependency labels May 23, 2024
@SchrodingersGat SchrodingersGat added this to the 0.16.0 milestone May 23, 2024
Copy link

netlify bot commented May 23, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 1594067
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/664f7e633d0bd30008a73a9c

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.78%. Comparing base (2fafb7f) to head (1594067).
Report is 315 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7309      +/-   ##
==========================================
- Coverage   83.78%   83.78%   -0.01%     
==========================================
  Files        1048     1048              
  Lines       45976    45975       -1     
  Branches     1386     1386              
==========================================
- Hits        38522    38521       -1     
  Misses       7091     7091              
  Partials      363      363              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member Author

@matmair I have raised this so we don't neglect to add uv back into the pipeline. But it looks like the recent updates to uv have ... broken things

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why this is not working anymore, I will look at the changelogs ASAP

@matmair
Copy link
Member

matmair commented May 23, 2024

Ok this seems somewhat intentional / not considered a bug astral-sh/uv#3765 (comment)

@matmair
Copy link
Member

matmair commented May 23, 2024

And astral-sh/uv#3767

@matmair
Copy link
Member

matmair commented May 23, 2024

At this point, I think we should either pin the latest working version or just go back to pip. There are 200 more important issues than fixing the CI every few uv updates

@SchrodingersGat
Copy link
Member Author

I'd support just going back to pip. uv has caused a lot of headaches and I agree it is not worth our time chasing this down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem dependency Relates to a project dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants