Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --fix and fix-all assist #223

Merged
merged 17 commits into from
Feb 4, 2024
Merged

Support --fix and fix-all assist #223

merged 17 commits into from
Feb 4, 2024

Conversation

rrousselGit
Copy link
Collaborator

@rrousselGit rrousselGit commented Feb 3, 2024

fixes #161

Screen.Recording.2024-02-03.at.12.14.36.mov

Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
custom-lint-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2024 2:56pm

@rrousselGit
Copy link
Collaborator Author

rrousselGit commented Feb 3, 2024

Needs testing.

Especially with regards to:

  • fixes emitting their fixes to a different file
  • multiple fixes overwriting the same offset (likely unsupported)
  • lints with no fixes
  • lints with multiple fixes
  • lints with fixes emitting multiple ChangeBuilders
  • --fix should not overwrite // ignore and // expect_lint
  • fix-all should not overwrite // ignore and // expect_lint
  • fix-all should not be visible if there's only a single fixed lint

@rrousselGit rrousselGit merged commit f0834db into main Feb 4, 2024
8 checks passed
@rrousselGit rrousselGit deleted the support-fix branch February 4, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable "fix all" options
1 participant