Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request: Add --offline flag to melos bootstrap. #714

Closed
1 task done
fischerscode opened this issue May 16, 2024 · 2 comments · Fixed by #756
Closed
1 task done

request: Add --offline flag to melos bootstrap. #714

fischerscode opened this issue May 16, 2024 · 2 comments · Fixed by #756
Labels
feature request Type: Accepted

Comments

@fischerscode
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues.

Command

melos bootstrap --offline

Description

There is the runPubGetOffline setting in melos.yaml and I'd love to see the same option for the cli.

Reasoning

This feature would be useful for CI.

Additional context and comments

My use case is a docker build and it's recommended to use --offline during these builds.
@spydon
Copy link
Collaborator

spydon commented Jun 5, 2024

Sounds good to me, is this something that you would like to implement @fischerscode?

@fischerscode
Copy link
Contributor Author

Sure, I'll give it a try.

nielsenko added a commit to realm/realm-dart that referenced this issue Jun 7, 2024
@nielsenko
A bit too clever. We need to wait for: invertase/melos#714
571fc60
fealebenpae added a commit to realm/realm-dart that referenced this issue Jun 7, 2024
@fealebenpae @nielsenko
[Release 3.0.0] (#1716)
925963c 
* [Release 3.0.0]

* A bit too clever. We need to wait for: invertase/melos#714

---------

Co-authored-by: nielsenko <nielsenko@users.noreply.github.com>
Co-authored-by: Kasper Overgård Nielsen <kasper@byolimit.com>
@spydon spydon mentioned this issue Sep 13, 2024
Merged
7 tasks
spydon added a commit that referenced this issue Oct 7, 2024
@spydon
feat: Expose pub get's --offline flag on the bootstrap command (#756
b432749 
)

<!--
  Thanks for contributing!

Provide a description of your changes below and a general summary in the
title

Please look at the following checklist to ensure that your PR can be
accepted quickly:
-->

## Description

Adds the `--offline` flag to the bootstrap command.

Fixes: #714 

## Type of Change

<!--- Put an `x` in all the boxes that apply: -->

- [x] ✨ `feat` -- New feature (non-breaking change which adds
functionality)
- [ ] 🛠️ `fix` -- Bug fix (non-breaking change which fixes an issue)
- [ ] ❌ `!` -- Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] 🧹 `refactor` -- Code refactor
- [ ] ✅ `ci` -- Build configuration change
- [ ] 📝 `docs` -- Documentation
- [ ] 🗑️ `chore` -- Chore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Type: Accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Expose pub get's --offline flag on the bootstrap command invertase/melos
2 participants
@spydon @fischerscode