-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): handle incoming and delivered events for remote notifications #229
Conversation
…aford/ios-remote-notifications-3
Codecov Report
@@ Coverage Diff @@
## helenaford/feat-apns-support #229 +/- ##
================================================================
+ Coverage 78.57% 78.58% +0.02%
================================================================
Files 29 29
Lines 1530 1531 +1
Branches 501 501
================================================================
+ Hits 1202 1203 +1
Misses 327 327
Partials 1 1 |
is there an ETA on this? thanks a million for making and open sourcing this 🙏 |
…e-notifications-3
8ffedb2
to
edff37f
Compare
can we have this merge? seems like it's fine and stuff |
Yes please |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Is there a reason this was closed? Seems still relevant |
Part two of handling events for notifications created outside of notifee.
Incoming
- fired when foreground presentation options are noneDelivered
event for notifications created outside of notifeeUpdate:
messaging_didReceiveRemoteNotification
is limiting, no completion handler so cannot process the event in background reliably without setting RNFB background handler.mutableContent
andcontentAvailable
together.