Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): handle incoming and delivered events for remote notifications #229

Closed
wants to merge 13 commits into from

Conversation

helenaford
Copy link
Member

@helenaford helenaford commented Nov 7, 2021

Part two of handling events for notifications created outside of notifee.

  • Introduces a new type of event Incoming - fired when foreground presentation options are none
  • Supports Delivered event for notifications created outside of notifee

Update:

  • messaging_didReceiveRemoteNotification is limiting, no completion handler so cannot process the event in background reliably without setting RNFB background handler.
  • TODO: Need to process data-only notifications as an incoming notification
  • Will no longer prefer didReceiveRemoteNotification over willPresentNotificaiton as it's bad practice to use both flags mutableContent and contentAvailable together.

@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #229 (d3e586d) into helenaford/feat-apns-support (49a0520) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@                       Coverage Diff                        @@
##           helenaford/feat-apns-support     #229      +/-   ##
================================================================
+ Coverage                         78.57%   78.58%   +0.02%     
================================================================
  Files                                29       29              
  Lines                              1530     1531       +1     
  Branches                            501      501              
================================================================
+ Hits                               1202     1203       +1     
  Misses                              327      327              
  Partials                              1        1              

Base automatically changed from helenaford/ios-remote-notifications-support to helenaford/feat-apns-support November 15, 2021 00:51
@icecapp
Copy link
Contributor

icecapp commented Nov 21, 2021

is there an ETA on this?

thanks a million for making and open sourcing this 🙏

@helenaford helenaford marked this pull request as ready for review November 29, 2021 09:48
@helenaford helenaford force-pushed the helenaford/feat-apns-support branch from 8ffedb2 to edff37f Compare June 1, 2022 22:48
@finalight
Copy link

can we have this merge? seems like it's fine and stuff

@frozencap
Copy link

Yes please

Base automatically changed from helenaford/feat-apns-support to main September 26, 2022 01:08
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Dec 6, 2022
@github-actions github-actions bot closed this Dec 21, 2022
@bensaine
Copy link

Is there a reason this was closed? Seems still relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants