fix: banners not properly destroyed #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~508 Documentation is deployed and generated using docs.page. |
1 task
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
==========================================
- Coverage 44.16% 43.74% -0.41%
==========================================
Files 29 29
Lines 530 535 +5
Branches 147 148 +1
==========================================
Hits 234 234
- Misses 296 301 +5 |
dylancom
force-pushed
the
bugfix/banner-memory-leak
branch
from
e93695f
to
22bceae
Compare
dylancom
changed the title
dylancom
force-pushed
the
bugfix/banner-memory-leak
branch
from
98743b2
to
bf0ebd2
Compare
|
🎉 This PR is included in version 12.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added methods to clean up the banner when a bannerView unmounts.
Might fix #496?
Please test.