Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

0.4.0 Release #12

Open
3 of 8 tasks
Ehesp opened this issue Jan 3, 2016 · 29 comments
Open
3 of 8 tasks

0.4.0 Release #12

Ehesp opened this issue Jan 3, 2016 · 29 comments

Comments

@Ehesp
Copy link
Member

Ehesp commented Jan 3, 2016

This list is a work in progress

  • Refactor List component
  • Implement GridView component
  • Implement Floating Action Button (FAB)
  • Swipe Views with Tabs (spec). Create a wrapper around react-native-scrollable-tab-view - maybe?
  • Animated IconToggle badge changes. c8f762e Released in 0.3.1
  • Create a core Ripple component, which handles device type a0fc633
  • Attempt to implement TouchableWithoutFeedback on polyfil/Ripple to properly handle onLong press and other props. b537e1c
  • NavIgation Drawer expandable/collapsable sections.
@bozzmob
Copy link
Contributor

bozzmob commented Jan 5, 2016

Anything more planned for 0.4.0, that I can take up? I guess you are handling the List Refactor.

@Ehesp
Copy link
Member Author

Ehesp commented Jan 5, 2016

The GridComponent? Also I need to debug a Ripple bug where the state persists. Any other ideas I'm open to!

@dgilperez
Copy link

What about a FAB?

@Ehesp
Copy link
Member Author

Ehesp commented Jan 5, 2016

Ah yeah. How should the position of it be done? Simply render the FAB and
let the user decide where to place it?
On 5 Jan 2016 9:00 p.m., "David Gil" notifications@github.com wrote:

What about a FAB?


Reply to this email directly or view it on GitHub
#12 (comment)
.

@dgilperez
Copy link

Hmm not really sure. Specs about fabs say how they should be positioned
with relation to other objects, and they seem to be always bottom-right ...
Maybe we can style them lime that by default and let the user override?

El mar, 5 de enero de 2016 22:02, Elliot Hesp notifications@github.com
escribió:

Ah yeah. How should the position of it be done? Simply render the FAB and
let the user decide where to place it?
On 5 Jan 2016 9:00 p.m., "David Gil" notifications@github.com wrote:

What about a FAB?


Reply to this email directly or view it on GitHub
<
#12 (comment)

.


Reply to this email directly or view it on GitHub
#12 (comment)
.

@pewh
Copy link

pewh commented Jan 6, 2016

What about a Bottom Sheet?

@bozzmob
Copy link
Contributor

bozzmob commented Jan 6, 2016

Yes. The FAB has to be at the bottom-right according to the spec.
Though FAB comes in handy, but, personally I somewhat like this article - Why the Floating Action Button is bad UX design

@Ehesp I can have a look at FAB, Gridview.

@bozzmob
Copy link
Contributor

bozzmob commented Jan 6, 2016

With respect to Grid View, I will be implementing this first (from the spec)-

image

@Ehesp
Copy link
Member Author

Ehesp commented Jan 6, 2016

@pewh problem with a bottom sheet is that currently there's no way to force a component to the top of everything else (I believe).

@bozzmob
Copy link
Contributor

bozzmob commented Jan 6, 2016

@pewh @Ehesp There is a way to do that. But, not sure its available on Android yet. We can tweak concepts and code from the Modal and implement it I believe. I have seen such an implementation somewhere. Not sure how good or feasible it is.

@Ehesp
Copy link
Member Author

Ehesp commented Jan 6, 2016

@bozzmob Okay cool - Shall look into it.

What does everyone think of 'Swipe Views with Tabs'? I've got it working on another project using the project mentioned in the list, but had to create a custom tab bar to make it feel native...?

@Salakar
Copy link
Member

Salakar commented Jan 6, 2016

jan 06 2016 19 13

Badge animations done!

@bozzmob
Copy link
Contributor

bozzmob commented Jan 6, 2016

@Ehesp Yeah! There is a ViewPager component which exists officially. We can make use of react-native-scrollable-tab-view as you have suggested. But, some css changes are needed so that the look and feel is similar to the existing components.

@Ehesp
Copy link
Member Author

Ehesp commented Jan 6, 2016

Nice work @Salakar, really cool.

@bozzmob I'll do that then as I've already got it on another project. react-native-scrollable-tab-view doesn't allow a single tab too, but I've got a way around that.

@bozzmob
Copy link
Contributor

bozzmob commented Jan 6, 2016

@Ehesp How about we use react-native-action-button for FAB?

@Ehesp
Copy link
Member Author

Ehesp commented Jan 6, 2016

That looks good! Will look if there's any benefit of pulling it in and making a wrapper around it. If not, it might just be best to suggest this for a FAB.

@zoontek
Copy link
Contributor

zoontek commented Jan 7, 2016

A dropdown menu component could be awesome!
But maybe it's a lot of work if it's a complete implementation (buttons, + textfields)

@Ehesp
Copy link
Member Author

Ehesp commented Jan 7, 2016

@zoontek I agree, however part of the problem we have (Bottom Sheets has this issue too), is that React Native does not yet support an "on the top of everything" API. So the dropdown menu might get stuck behind a component which is nested deeper down the chain.

@bozzmob
Copy link
Contributor

bozzmob commented Jan 7, 2016

I am working on the Gridview component now. Have made some progress. Still a lot to do.

@bozzmob
Copy link
Contributor

bozzmob commented Jan 7, 2016

Screenshots of Gridview-

Currently, its working for a fixed height, width.

I am working on making it a generic component. Currently most values like margin, padding are being hard-coded. So, thought of making it responsive.

image

image

@Salakar
Copy link
Member

Salakar commented Jan 11, 2016

@bozzmob any updates on the grid view?

@bozzmob
Copy link
Contributor

bozzmob commented Jan 12, 2016

@Salakar Yes. I am working on it. It should be available in a couple of days.

@Salakar Salakar added this to the 0.4.0 Release milestone Jan 14, 2016
@zoontek
Copy link
Contributor

zoontek commented Jan 25, 2016

The dropdown is available in React-Native 0.19-rc: facebook/react-native@1843709 👍

@Ehesp
Copy link
Member Author

Ehesp commented Jan 25, 2016

Awesome :D

I just wish there was some "z-index" type style so we could push whatever we wanted to the top of the stack.

@zoontek
Copy link
Contributor

zoontek commented Feb 29, 2016

Is the project dead? :(

@Ehesp
Copy link
Member Author

Ehesp commented Feb 29, 2016

Nope, was using it in a internal work project however that's not currently being developed so focus has shifted. Plan on picking it up in the next few weeks hopefully.

@zoontek
Copy link
Contributor

zoontek commented Feb 29, 2016

Great!

@anhldbk
Copy link

anhldbk commented Mar 7, 2016

@Ehesp Any chance to integrate with https://github.com/xinthink/react-native-material-kit?

@kkgelu
Copy link

kkgelu commented Mar 11, 2016

I would like to have a proper dialog (in future releases), example:
https://github.com/aakashns/react-native-dialogs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants