add option to CLI and pngwriter that allows user to set PNG compression level #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on level - In CLI: the argument is --png_compression <0..9> (-z<0..9>) - In API, pass `compress_level` to PngWriter.save_image_and_prompt_to_png() Compression ranges from 0 (no compression) to 9 (maximum compression). Default value is 6 (as specified by Pillow package). This addresses an issue first raised in #652.
|
Will this be "sticky", like setting the sample scheduler from the CLI? |
It isn't currently. The value specified on the command line is the default level of compression. Individual invoke> commands can change it, but just for that one command. I learned belatedly that PNG compression isn't lossy like JPG, and so this won't fix the problem we observe with loss of fidelity across multiple img2img passes. This seems to be an artefact of the diffusion process itself. |
This is what I meant by "sticky" :D |
|
Then the answer is "yes"
L
…On Mon, Oct 17, 2022 at 1:32 PM tildebyte ***@***.***> wrote:
The value specified on the command line is the default level of
compression. Individual invoke> commands can change it, but just for that
one command
This is what I meant by "sticky" :D
—
Reply to this email directly, view it on GitHub
<#1127 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3EVK6U4WDLZHKLUWXDWDWDWEUDANCNFSM6AAAAAARGM3XC4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
tildebyte
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running
img2imgrepeatedly on the same image, the PNG compression/decompression artefacts add up.Solution
This PR adds a new feature that enables the user to change the level of PNG compression used, including turning it off completely.
Details
-- this can be applied either on the command line, or at the
invoke>promptcompress_levelto PngWriter.save_image_and_prompt_to_png()Compression ranges from 0 (no compression) to 9 (maximum compression). Default value is 6 (as specified by Pillow package).
This addresses an issue first raised in #652.