Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PaperCut and VoxelArt models load again #1730

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

lstein
Copy link
Collaborator

@lstein lstein commented Dec 2, 2022

This corrects a regression in loading of these models due to a change of the embedding_manager parameter num_vectors_per_token

Reverting to the original version (1) does not seem to affect concept embeddings.

Fixes #1718

This corrects a regression in loading of these models due to
a change of the embedding_manager parameter `num_vectors_per_token`

Fixes #1718
@lstein
Copy link
Collaborator Author

lstein commented Dec 3, 2022

@damian0815 I do not recall why we changed num_vectors_per_token from 1 to 8. If there is a good reason for it to be 8, I will make a new inference configuration file and use it when the PaperCut and VoxelArt models are configured. Please let me know.

@damian0815
Copy link
Contributor

damian0815 commented Dec 3, 2022

also fixes #1657

after setting this back to 1, please test if https://huggingface.co/datasets/Nerfgun3/bad_prompt/blob/main/bad_prompt_version2.pt loads (it has a vector length of 8)

i do not know how to verify if it's actually working but @blessedcoolant has a prompt created in a similar way.

@lstein
Copy link
Collaborator Author

lstein commented Dec 3, 2022

also fixes #1657

after setting this back to 1, please test if https://huggingface.co/datasets/Nerfgun3/bad_prompt/blob/main/bad_prompt_version2.pt loads (it has a vector length of 8)

i do not know how to verify if it's actually working but @blessedcoolant has a prompt created in a similar way.

Both bad_prompt.pt and bad_prompt_version2.pt load as embeddings without any obvious problems. I don't understand what this negative prompt is supposed to do, but using it created images that looked OK.

@tildebyte
Copy link
Contributor

I don't understand what this negative prompt is supposed to do

IIUC, it's a "stock" negative prompt which one would use for all generations by including 'bad_prompt' or some such in every prompt (as opposed to copy-pasting a long list every time). Impossible to tell what it actually does without knowing what terms are included in the negation list.

@hipsterusername
Copy link
Member

a bunch of the ones we make fun of for being pointless. nevertheless, commonly used.

@damian0815
Copy link
Contributor

right, it's just that not knowing what it does makes it hard to know if it's being loaded correctly (all 8 vectors) or if it's being truncated (just the 1st vector is loaded/used and it "seems" ok but actually isnt).

Copy link
Contributor

@damian0815 damian0815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge it

@damian0815 damian0815 merged commit 44a0055 into main Dec 5, 2022
@damian0815 damian0815 deleted the revert-vectors-per-token branch December 5, 2022 18:04
@damian0815 damian0815 mentioned this pull request Dec 5, 2022
1 task
@thinkyhead
Copy link
Contributor

I've just updated main using Git and running the latest, and I see Papercut and voxel_art are not currently loading. Do we need to run any update scripts to get these to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: PaperCut checkpoint cannot be loaded
5 participants