ui: edesign followups 3 #5385
Merged
ui: edesign followups 3 #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername,
Kyle0654 and
brandonrising
as code owners
Millu
approved these changes
Jan 3, 2024
hipsterusername
approved these changes
Jan 3, 2024
Got borked when adjusting control adapter styling. Should revisit this later.
Helpful for troubleshooting.
Ensure workflow editor model selector component gets a value This introduced some funky type issues related to ONNX models. ONNX doesn't work anyways (unmaintained). Instead of fixing the types to work with a non-working feature, ONNX is now removed entirely from the UI. - Remove all refs to ONNX (and Olives) - Fix some type issues - Add ONNX nodes to the nodes denylist (so they are not visible in UI) - Update VAE graph helper, which still had some ONNX logic. It's a very simple change and doesn't change any logic. Just removes some conditions that were for ONNX. I tested it and nothing broke. - Regenerate types - Fix prettier and eslint ignores for generated types - Lint
`react-select` has some weird behaviour where if the value is `undefined`, it shows the last-selected value instead of nothing. Must fall back to `null`
- Do not _merge_ prompt and style prompt when concat is enabled - either use the prompt as style, or use the style directly. - Set style prompt metadata correctly. - Add metadata recall for style prompt.
Weird issue with `react-select`... Made the popover lazy as a workaround. Also updated styling of the popover.
…isable on spacebar
- Add Shift+X back (this has been missing for a long time) - Add secondary toggle options hotkey
psychedelicious
force-pushed
the
feat/ui/redesign-followups-3
branch
from
b5e20c4
to
dcc878f
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Numerous fixes and enhancements - see commits.
Related Tickets & Documents
Closes #5384
Closes #5383
Closes #5379
Several threads scattered across discord etc.
QA Instructions, Screenshots, Recordings
Same same but different
Merge Plan
This PR can be merged when approved
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
Nope