feat: pin deps #5465
Merged
feat: pin deps #5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Organise deps into ~3 categories: - Core generation dependencies, pinned for reproducible builds. - Core application dependencies, pinned for reproducible builds. - Auxiliary dependencies, pinned only if necessary. I pinned / bumped these to latest: - `controlnet_aux` - `fastapi` - `fastapi-events` - `huggingface-hub` - `numpy` - `python-socketio` - `torchmetrics` - `transformers` - `uvicorn` I checked the release notes for these and didn't see any breaking changes that would affect us. There is a `fastapi` breaking change in v108 related to background tasks but it doesn't affect us. I tested on a fresh venv. The app still works and I can generate on macOS. Hopefully, enforcing explicit pinned versions will reduce the issues where people get CPU torch. It also means we should periodically bump versions up to ensure we don't get too far behind on our dependencies and have to do painful upgrades.
psychedelicious
requested review from
lstein,
ebr,
hipsterusername and
blessedcoolant
as code owners
hipsterusername
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Organise deps into ~3 categories:
I pinned / bumped these to latest:
controlnet_auxfastapifastapi-eventshuggingface-hubnumpypython-socketiotorchmetricstransformersuvicornI checked the release notes for these and didn't see any breaking changes that would affect us. There is a
fastapibreaking change in v108 related to background tasks but it doesn't affect us.I tested on a fresh venv. The app still works and I can generate on macOS.
Hopefully, enforcing explicit pinned versions will reduce the issues where people get CPU torch.
It also means we should periodically bump versions up to ensure we don't get too far behind on our dependencies and have to do painful upgrades.
QA Instructions, Screenshots, Recordings
I don't expect any issues with the minor version bumps involved. I've tested on macOS so far. I'll test on linux shortly, and it would be great to test on window too.
But, if we cut an RC, is much more effective a way to test.
Merge Plan
This PR can be merged when approved.