Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DW Openpose Processor #5688

Merged
merged 11 commits into from
Feb 12, 2024
Merged

Conversation

blessedcoolant
Copy link
Collaborator

@blessedcoolant blessedcoolant commented Feb 9, 2024

What type of PR is this? (check all applicable)

  • Feature

Have you discussed this change with the InvokeAI team?

  • Yes

Have you updated all relevant documentation?

  • No

Description

This PR adds the DW Openpose Image Processor for ControlNet to InvokeAI.

  • Added a new node: DW Openpose Image Processor - This node takes in an image and lets you generate an openpose skeleton from it. You are able to generate the body skeleton, hand skeleton and also the facial landmarks selectively.
  • DW Openpose Processor has been implemented in the Linear UI. It is also now the default processor for Openpose.

Removed

The old Openpose Image Processor has been entirely removed. Any current workflow using this node will break. But the fix is simple. Just replace it with the new DW Openpose Image Processor and you are good to go.

After Merge

  • Update the docs to reflect this change

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations backend PRs that change backend files labels Feb 9, 2024
@blessedcoolant blessedcoolant changed the title feat: DWPose Processor feat: DWPose Openpose Processor Feb 9, 2024
@github-actions github-actions bot added the frontend PRs that change frontend files label Feb 9, 2024
@blessedcoolant blessedcoolant marked this pull request as ready for review February 9, 2024 22:05
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just would like to have types on our code, and attribution for code that was copied

@Millu
Copy link
Contributor

Millu commented Feb 11, 2024

Should we default the processor to hands as well?

@hipsterusername
Copy link
Member

works for me. have we had a test on mac?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 11, 2024
@blessedcoolant
Copy link
Collaborator Author

@Millu Millun, could you update (or point out to me) the docs that need to reflect the fact that the Openpose Image Processor is now removed entirely and the new way to do Openpose is with the DW Openpose Processor and that this will break older workflows that use the other processor.

@blessedcoolant blessedcoolant changed the title feat: DWPose Openpose Processor feat: DW Openpose Processor Feb 11, 2024
Copy link
Contributor

@Millu Millu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated docs & tested on macOS

@blessedcoolant
Copy link
Collaborator Author

@hipsterusername Good to merge I think.

@Millu
Copy link
Contributor

Millu commented Feb 11, 2024

Let's hold to merge until 3.6.3 is released as this will introduce a breaking change

@hipsterusername hipsterusername enabled auto-merge (rebase) February 12, 2024 16:06
@hipsterusername hipsterusername merged commit 1dd07fb into invoke-ai:main Feb 12, 2024
8 checks passed
@blessedcoolant blessedcoolant deleted the dw-pose branch February 12, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend PRs that change backend files documentation Improvements or additions to documentation frontend PRs that change frontend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants