Remove civit install source #5887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonrising
requested review from
psychedelicious,
blessedcoolant,
maryhipp,
hipsterusername,
lstein,
GreggHelt2 and
RyanJDick
as code owners
github-actions
bot
added
python
maryhipp
approved these changes
Mar 7, 2024
hipsterusername
approved these changes
Mar 7, 2024
… all remote url model downloads
A list of regex and token pairs is accepted. As a file is downloaded by the model installer, the URL is tested against the provided regex/token pairs. The token for the first matching regex is used during download, added as a bearer token.
psychedelicious
force-pushed
the
remove-civit-install-source
branch
from
f63bc6e
to
721280f
Compare
psychedelicious
force-pushed
the
remove-civit-install-source
branch
from
ecd55b7
to
2d82bb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
After this change, civitAI model downloads will be treated as any other URL and no metadata will be stored. I've added a new config variable named remote_repo_api_key that will add the key as a query param named
tokenon all remote model downloads. This is just a stop gap until we decide how we want to handle more robust management of query params/tokens/etc in our model management UI. There could be unintended consequences of passing that token to a site you didn't mean to.Related Tickets & Documents
This PR came out of various discussions related to explicit support for CIVIT AI model imports in our codebase in the #dev-chat channel of our discord.
QA Instructions, Screenshots, Recordings
Merge Plan
This PR can be merged when approved
Added/updated tests?
have not been included