Revert "fix(mm): provide ckpt config as stream to diffusers" #5990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9d04596.
lstein
requested review from
blessedcoolant,
GreggHelt2,
brandonrising,
RyanJDick and
hipsterusername
as code owners
github-actions
bot
added
python
psychedelicious
approved these changes
Mar 19, 2024
brandonrising
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9d04596.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
This reverses a workaround that was originally applied to accommodate a bug in the diffusers model conversion code. This bug was fixed upstream and the workaround is no longer needed.
Related Tickets & Documents
See discord thread https://discord.com/channels/1020123559063990373/1149513647022948483/1219457860321284096
QA Instructions, Screenshots, Recordings
With the current diffusers (version 0.27.0) remove the conversion
models/.cachedirectory and then try to generate using a checkpoint model. It should convert and render correctly.Merge Plan
Merge when approved.
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?