fix: handle custom node errors on startup, clear session queue via migration #6100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
psychedelicious
changed the title
hipsterusername
approved these changes
Apr 2, 2024
Previously, exceptions raised as custom nodes are initialized were fatal errors, causing the app to exit. With this change, any error on import is caught and the error message printed. App continues to start up without the node. For example, a custom node that isn't updated for v4.0.0 may raise an error on import if it is attempting to import things that no longer exist.
Empties the session queue. This is done to prevent any lingering session queue items from causing pydantic errors due to changed schemas.
psychedelicious
force-pushed
the
psyche/fix/v4-followups
branch
from
dcfb742
to
10df85d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Custom node import errors could crash the app on startup. For example, if a custom node isn't updated for v4.0.0, it might try to import an nonexistent class from the invokeai python package. These errors are how handled gracefully - an error message is printed to the python terminal and the app startups up normally.
Empty the session queue during data migration. This prevents pydantic errors from spamming the terminal on startup, if the queue items are no longer valid. This can occur if we change any pydantic schemas from
SessionQueueItemand on downward.Related Issues / Discussions
Discord thread: https://discord.com/channels/1020123559063990373/1020123559831539744/1224527169753976956
(thanks for raising @empessah)
QA Instructions
Node error:
Session Queue:
Merge Plan
The release notes should include a blurb about the queue being cleared on first run. Probably a good idea to do this for every release.
Checklist