fix(config): handle windows paths in invokeai.yaml migration for legacy_conf_dir #6101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy_conf_dir The logic incorrectly set the `legacy_conf_dir` on windows, where the slashes go the other direction. Handle this case and update tests to catch it.
psychedelicious
requested review from
blessedcoolant,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
hipsterusername
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The logic incorrectly set the
legacy_conf_diron windows, where the slashes go the other direction. Handle this case and update tests to catch it.Related Issues / Discussions
An issue where the conversion YAML configs were not located correctly started the investigation:
https://discord.com/channels/1020123559063990373/1224562758469681272
QA Instructions
invokeai.yamlwithlegacy_conf_dirset toconfigs\stable-diffusion(note the slash)invokeai.yamlagain, there should be nolegacy_conf_dirsetting now (because we detected it was using the default value)Merge Plan
It'd be nice if @empessah could confirm deleting the
legacy_conf_dirin the newinvokeai.yamlfile fixes the issue, but this is definitely a bug regardless.Checklist