fix(ui): CA processor cancellation #6336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a control adapter processor config is changed, if we were already processing an image, that batch is immediately canceled. This prevents the processed image from getting stuck in a weird state if you change or reset the processor at the right (err, wrong?) moment.
Related Issues / Discussions
Original report @JPPhoto https://discord.com/channels/1020123559063990373/1149506274971631688/1238153079950676101:
QA Instructions
The debounce is 300ms, so if you time it right, you can trigger all possible behaviours, which I will not enumerate here bc its complicated. In short, no matter how your poke it, it should be responsive and not break.
With a processor selected, it should either be processing the image or showing the processed image. With no processor, it should be showing the original image. If you change the processor in any way while it is mid-processing, it should cancel the pending processing.
Merge Plan
n/a
Checklist