Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Update min and max values for LoRACard weight input #6383

Merged
merged 1 commit into from
May 17, 2024
Merged

[Refactor] Update min and max values for LoRACard weight input #6383

merged 1 commit into from
May 17, 2024

Conversation

H0onnn
Copy link
Contributor

@H0onnn H0onnn commented May 17, 2024 •
edited

Summary

Update min and max values for LoRACard Component.

A simple fix for issue #6337 has been added. But I don't know if this is best.

Do you have any opinions on what is the best way to set the minimum and maximum values?

Related Issues / Discussions

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the frontend PRs that change frontend files label May 17, 2024
psychedelicious
psychedelicious approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is the right way to change this. There are no backend changes needed.

@psychedelicious psychedelicious enabled auto-merge (rebase) May 17, 2024 00:36
@psychedelicious psychedelicious merged commit 31d8b50 into invoke-ai:main May 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enhancement]: increasing LoRA weight cap
2 participants
@H0onnn @psychedelicious