Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): workflow resource check #6417

Merged
merged 3 commits into from
May 21, 2024
Merged

Conversation

psychedelicious
Copy link
Collaborator

Summary

These fields are reset back to undefined if not accessible. A warning toast is showing, and in the JS console, the full warning message is logged.

Related Issues / Discussions

n/a

QA Instructions

There are tests for this functionality. To test manually:

  • Create a board
  • Create a workflow with an image resize node
  • Set the board to the new board
  • Set an image
  • Check the data tab in the bottom left panel of the workflow editor and check that the value for the board and image are populated
  • Save the workflow
  • Delete the board and image
  • Refresh the page
  • Re-load the workflow
  • Check the data tab in bottom left panel of the workflow editor and check that the value for the board and image are now undefined

Then do the same thing, but with the model loader. You'll need to delete the model between the reloads.

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

These fields are reset back to `undefined` if not accessible. A warning toast is showing, and in the JS console, the full warning message is logged.
@github-actions github-actions bot added the frontend PRs that change frontend files label May 21, 2024
@psychedelicious psychedelicious changed the title Psyche/feat/UI/resource check feat(ui): workflow resource check May 21, 2024
@hipsterusername hipsterusername merged commit 38265b3 into main May 21, 2024
14 checks passed
@hipsterusername hipsterusername deleted the psyche/feat/ui/resource-check branch May 21, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants