Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): metadata recall fixes #6480

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

Two metadata recall fixes:

  • Fallback to recalling models by name, base and type when the model's key no longer exists. This allows models that were installed, deleted, and re-installed with the same name to be recalled.
  • Set the prompt concat flag correctly when recalling prompts.

Related Issues / Discussions

Closes #6478

QA Instructions

Test model recall:

  • Generate w/ whatever model - can be main, LoRA, whatever
  • Note the model's name
  • Delete the model
  • Reinstall the model
  • Ensure the reinstalled model has the same name as you noted earlier
  • Check metadata for the image, it should show the model and let you recall it

Test prompt concat:

  • Generate an image with concat enabled
  • Disable concat
  • Recall prompts/all - concat should enable
  • Generate an image with concat disabled and with style prompts that are different from the main prompts
  • Enable concat
  • Recall prompts/all - concat should disable

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the frontend PRs that change frontend files label Jun 3, 2024
@psychedelicious psychedelicious enabled auto-merge (rebase) June 3, 2024 19:58
When the model in metadata's key no longer exists, fall back to fetching by name, base and type. This was the intention all along but the logic was never put in place.
This required some minor reworking of of the logic to recall multiple items. I split this into a utility function that includes some special handling for concat.

Closes #6478
@psychedelicious psychedelicious force-pushed the psyche/fix/ui/metadata-recall-fixes branch from 32fa4a8 to 231de3c Compare June 3, 2024 19:59
@psychedelicious psychedelicious merged commit 64523c4 into main Jun 3, 2024
14 checks passed
@psychedelicious psychedelicious deleted the psyche/fix/ui/metadata-recall-fixes branch June 3, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: When recalling prompts, "style" prompts are not always recalled correctly
2 participants