Properly parsing transferLock param in resource_domain.go #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "domain.info" method of the INWX JsonRPC API returns a boolean for the property transferLock. The provider expects a float for some reason. Maybe that was a bug in the API that INWX already has fixed. The type for this property can be confirmed at https://www.inwx.com/en/help/apidoc/f/ch02s09.html#domain.info. I have tested it myself and it is indeed a boolean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "domain.info" method of the INWX JsonRPC API returns a boolean for the property transferLock. The provider expects a float for some reason. Maybe that was a bug in the API that INWX already has fixed. The type for this property can be confirmed at https://www.inwx.com/en/help/apidoc/f/ch02s09.html#domain.info. I have tested it myself and it is indeed a boolean.