Fix deletes & updates breaking on "unexpected end of JSON input" #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call is always attempting to parse response body, which leads to errors in case of no-response calls such as nameserver.deleteRecord. In order to allow for such without breaking our API, let's: * rename the original Call into _Call * introduce a boolean of `expectResponseBody` into _Call * offer a new Call that keeps the stable interface, but translates into _Call(..., true) * offer a new CallNoResponseBody that can be used by such no-response calls
According to API, the underlying calls don't return any response body. Use client.CallNoResponseBody instead of client.Call and avoid erroring on body failing to parse (as it is empty). Given the empty body, no call.Code is available, so remove this part as well.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call is always attempting to parse response body, which leads to errors in case
of no-response calls such as nameserver.deleteRecord.
In order to allow for such without breaking our API, let's:
expectResponseBodyinto _CallThen,
Use the new
client.CallNoResponseBodyinstead of client.Call and avoid erroringon body failing to parse in NameserverRecordUpdate & NameserverRecordDelete.
Fixes #12