Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove last traces of account-specific branding #18

Closed
io7m opened this issue Jan 8, 2018 · 1 comment
Closed

Remove last traces of account-specific branding #18

io7m opened this issue Jan 8, 2018 · 1 comment
Assignees
@io7m
Labels
profiles

Comments

@io7m
Copy link
Owner

io7m commented Jan 8, 2018

It no longer makes sense for different accounts to get different action bar and text colors. Any reference to mainColor from the account provider configuration should be audited and most likely removed.
@io7m io7m added the profiles label Jan 8, 2018
@io7m io7m self-assigned this Jan 8, 2018
io7m added a commit that referenced this issue Jan 8, 2018
@io7m
Remove account-specific branding
84f7b0c 
This stops using the color information from whatever is the provider
of the current account.

Fix #18
Affects #5
@io7m
Copy link
Owner Author

io7m commented Jan 9, 2018

This is done.

To bring back account-specific branding, it'll be necessary to construct themes/styles at runtime instead of having them defined in XML (because those themes might be coming from a remote server).

@io7m io7m closed this as completed Jan 9, 2018
winniequinn pushed a commit to AULFA/android that referenced this issue Feb 20, 2018
@io7m @winniequinn
Remove account-specific branding
8613113 
This stops using the color information from whatever is the provider
of the current account.

Fix io7m#18
Affects io7m#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@io7m io7m

Labels
profiles
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@io7m