Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title bar close/maximize button icons #25

Closed
io7m opened this issue Jul 23, 2016 · 1 comment
Closed

Title bar close/maximize button icons #25

io7m opened this issue Jul 23, 2016 · 1 comment
Assignees
@io7m
Labels
architecture enhancement

Comments

@io7m
Copy link
Member

io7m commented Jul 23, 2016

Somehow, themes need a way to specify the icons for window title bar close/maximize buttons.
@io7m io7m self-assigned this Jul 23, 2016
@io7m
Copy link
Member Author

io7m commented Jul 23, 2016 •
edited
Loading

One issue is that the theme may specify a name for an image, but it is up to whatever image cache (or more specifically the image cache's resolver function) the renderer is using to map that name to an image file. The theme has no control over exactly which file will be used. The best that can be done here is to establish a convention for names.

io7m added a commit that referenced this issue Jul 23, 2016
@io7m
Title bar button icons
5364279 
This adds a set of icons for each provided theme, and provides
a means for themes to set icons. Additionally, close and
maximize buttons now implement window-specific interfaces
(SyWindowCloseButtonType, SyWindowMaximizeButtonType).

The ability for image themes to set outlines has been removed, as
this should arguably be provided by something else.

Fix #25
@io7m io7m closed this as completed Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@io7m io7m

Labels
architecture enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@io7m