Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split component layout function #47

Open
io7m opened this issue Dec 8, 2023 · 0 comments
Open

Split component layout function #47

io7m opened this issue Dec 8, 2023 · 0 comments

Comments

@io7m
Copy link
Member

io7m commented Dec 8, 2023

The current layout() function declared on the SyComponentType does the necessary grunt work to lay out the current component, but it then goes on to call layout() on the child components. While it should do this, some components that override this method are only interested in the first half of the work that the method does. Unfortunately, they only have the option to call the entire method and possibly end up laying out child components twice.

Three methods should be provided: layoutThis, layoutChildren and layout. layout calls layoutThis and then layoutChildren. Overrides of layout can call layoutThis and layoutChildren as necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant