Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added notification-manager to latest #2330

Merged
merged 1 commit into from
Jul 26, 2023
Merged

added notification-manager to latest #2330

merged 1 commit into from
Jul 26, 2023

Conversation

foxriver76
Copy link
Collaborator

No description provided.

@GermanBluefox GermanBluefox added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Jun 2, 2023
@ioBroker ioBroker deleted a comment from mcm1957 Jun 2, 2023
@foxriver76
Copy link
Collaborator Author

I think BF needs to accept the invite first.

@mcm1957
Copy link
Collaborator

mcm1957 commented Jun 2, 2023 •
edited
Loading

I think BF needs to accept the invite first.

Yes, thats OK
I just wunder why [E802] no topics is reported while I clearly can see some ?
Maybe some chaching ...

Ist it importangt for you to get in latest due to js-controller relations? Apollon77 is not really available currently. I can review the adapter into latest - I'm sure that I cannot detect any problems within your code :-) and maybe Apollon77 will neither. If its not urgent, I'll let it wait for Appollon77 ..

@foxriver76
Copy link
Collaborator Author

It is no longer displayed in the update ;-)

@mcm1957
Copy link
Collaborator

mcm1957 commented Jun 2, 2023

It is no longer displayed in the update ;-)

OK - caching problem.
AT MY BROWSER I ASSUME :-).

Let me know if you prefer / need an urgent release. Otherwise the lates requests are planned to be processed in app. 2 weeks.

@foxriver76
Copy link
Collaborator Author

No hurries. Thanks for your effort.

@mcm1957 mcm1957 added lgtm Looks Good To Me Adapter-Review needed A developer from the ioBroker Team will review the adapter, will provide comments or require changes and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Jun 2, 2023
@ioBroker ioBroker deleted a comment from mcm1957 Jun 2, 2023
@GermanBluefox
Copy link
Contributor

Automated adapter checker

ioBroker.notification-manager

Downloads
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W400] Cannot find "notification-manager" in latest repository

Add comment "RE-CHECK!" to start check anew

@Apollon77 Apollon77 merged commit 31964e9 into master Jul 26, 2023
@mcm1957 mcm1957 deleted the notification-manager-latest branch August 3, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Adapter-Review needed A developer from the ioBroker Team will review the adapter, will provide comments or require changes auto-checked This PR was automatically checked for obvious criterias lgtm Looks Good To Me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foxriver76 @mcm1957 @GermanBluefox @Apollon77