Removed caching of Table values #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One consequence of using streams is that it isn't possible for |
| @@ -117,7 +115,7 @@ def initialize_plot(self, ranges=None): | |||
| for col in range(element.cols): | |||
| if summarize and row > half_rows: | |||
| adjusted_row = (element.rows - self.max_rows + row) | |||
| cell_value = self.cell_values[self.keys[-1]][(row, col)] | |||
| cell_value = element.pprint_cell(row, col) | |||
There was a problem hiding this comment.
Shouldn't both of these calls also pass the return value through the pprint_value method on TablePlot, I'm not sure why both the element and the plot need a pprint method but I assume there was a reason.
There was a problem hiding this comment.
Well spotted! I've just pushed a commit to fix this.
|
Looks good now. Happy to merge when tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Tables to be updated with streams by disabling the caching of cell values in TablePlot. I've tested that streams now work but I won't be confident that everything is working as it should until the tests pass.