Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering on variants results in different set of variants when launching saved analysis vs. launching with variant set. #924

Closed
tonydisera opened this issue Apr 10, 2023 · 2 comments · Fixed by #948
Assignees
Labels
bug Something isn't working
Milestone

Comments

@tonydisera
Copy link
Collaborator

tonydisera commented Apr 10, 2023

See Analysis A1130. There are 126 filtered variants that don't pass any of the gene.iobio standard filters. These are not showing up in the saved analysis.

Also, there is a De novo variant that doesn't show up under the De novo filter when launched from the variant set (called Slivar filtered variants). But when launching from the saved analysis, the De novo variant does show up under the appropriate filter.
Screenshot 2023-04-09 at 6 11 36 PM

Notice that the variant shows up under 'filtered variants' when gene.iobio launched with the variant set. This is b/c it doesn't match the De novo filter since it is an inframe deletion. So why does it pass the filter after it is saved as an analysis??

@tonydisera tonydisera added the bug Something isn't working label Apr 10, 2023
@tonydisera tonydisera self-assigned this Apr 10, 2023
@tonydisera tonydisera transferred this issue from iobio/clin.iobio Apr 10, 2023
@tonydisera tonydisera added this to the gene 4.7.1 milestone Apr 10, 2023
@tonydisera tonydisera pinned this issue Apr 10, 2023
@tonydisera
Copy link
Collaborator Author

In particular, there is a de novo variant in gene SPRX that is in the 'slivar prioritized variant'. When gene.iobio is launched with the variant set, this variant shows up under 'filtered variants', meaning it didn't pass any of the standard filters, which is odd, b/c it does seem to pass the 'De novo' filter criteria. Then, if I click on the gene in the genes panel, the variant moves under the 'De novo variants' filter.
You can try this by launching with the 'Tony - troubleshooting SPRX' variant set.

@tonydisera
Copy link
Collaborator Author

So we know there are a few problems here:

  1. The filters should be sorted based on the way they are originally ordered on a fresh launch of gene.iobio. This order is not being maintained when launching a saved analysis.
  2. The 'filtered variants' (variants in variant set, but not passing any of the gene.iobio filters) are getting lost after saving analysis. These variants need to be restored when the saved analysis is launched
  3. There is an inconsistency in how a variant is passing a filter when launched from a variant set vs when the gene is clicked.

@tonydisera tonydisera unpinned this issue Apr 21, 2023
@tonydisera tonydisera linked a pull request Jul 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant