Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision browser shouldn't show unsaved changes when there are no changes #2046

Closed
wlach opened this issue Jul 17, 2019 · 0 comments
Closed

Comments

@wlach
Copy link
Contributor

wlach commented Jul 17, 2019

Currently the iodide revision browser shows an unsaved changes when the notebook is already fully up to date:

image

We should only show this item when there are changes not yet synchronized with the server (i.e. we actually have a difference to show, not just "no difference").

The logic to display this item in the list is here:

<ListItemText primary="Unsaved Changes" />

The logic to calculate the difference between two revisions is here, it might provide some hints on how to implement this feature:

https://github.com/iodide-project/iodide/blob/e361ed03c6ae04c015a1ba19e4f51dd012870f4e/src/editor/components/modals/revision-diff.jsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant