Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision browser should allow reverting notebook to previous state #2047

Closed
wlach opened this issue Jul 17, 2019 · 3 comments
Closed

Revision browser should allow reverting notebook to previous state #2047

wlach opened this issue Jul 17, 2019 · 3 comments

Comments

@wlach
Copy link
Contributor

wlach commented Jul 17, 2019

Currently the revision browser lets you view a summary of what changed, but doesn't let you actually revert the notebook content to that of a previous revision.

image

We should, at minimum, add a button to do exactly like this. Before actually replacing the content, it should pop up a warning dialog confirming the user wants to do this. Google docs provides a good UI example on how this is done:

image

Depending on where we go with iodide, we probably want to enable other things in the future (e.g. forking a "branch" from a previous revision) but for now this will move the ball forward a bit.

@ZiyaoWei
Copy link
Contributor

ZiyaoWei commented Aug 4, 2019

Interested in contributing to Iodide - is this issue a good first issue to pickup? If not, I'll browse around and try to find something else (open to suggestions!).

@wlach
Copy link
Contributor Author

wlach commented Aug 4, 2019

Interested in contributing to Iodide - is this issue a good first issue to pickup? If not, I'll browse around and try to find something else (open to suggestions!).

I think @mehmetoguzderin wanted to pick this one up, #2114 which you filed would be a good first issue to try. I can probably suggest other things on gitter when I get back in on Tuesday.

@bcolloran
Copy link
Contributor

this functionality was added somewhere along the way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants