Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our docker images should be built using a multi-stage builds #2156

Closed
wlach opened this issue Aug 15, 2019 · 2 comments
Closed

Our docker images should be built using a multi-stage builds #2156

wlach opened this issue Aug 15, 2019 · 2 comments

Comments

@wlach
Copy link
Contributor

wlach commented Aug 15, 2019

@armenzg just taught me about multistage docker builds, I think we use these for generating the iodide docker images. Advantages:

  • Much smaller images we can use deployment (should speed up deploys internally, and on Heroku whenever we start using docker images there)
  • Can much more easily create a "production" image without dev and test dependencies (should probably do that as part of this work)

The version of docker used to generate the images must be relatively recent (17.05 or higher), but I believe the resulting images can be used just about anywhere.

Here's an example file, much of what's in here would apply to iodide as well: https://github.com/mozilla/bedrock/blob/master/Dockerfile

This isn't a "good first bug" in the sense that some of the exact details of the work required are undefined but should be relatively approachable to someone newish to iodide. I would recommend reading the section on https://iodide-project.github.io/docs/local-dev/ before diving in.

@wlach wlach changed the title Our docker image should use a multi-stage image Our docker images should be built using a multi-stage builds Aug 15, 2019
@Algentile
Copy link
Contributor

Hey @wlach,

I was looking into this earlier last week, I can start working on this.

@wlach wlach assigned wlach and Algentile and unassigned wlach Aug 15, 2019
@wlach
Copy link
Contributor Author

wlach commented Aug 15, 2019

@Algentile fantastic! I will assign to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants