Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertically align text in language selector (fixes #2446) #2450

Merged
merged 4 commits into from
Nov 18, 2019

Conversation

nikijiandani
Copy link
Contributor

@nikijiandani nikijiandani commented Nov 18, 2019

Pull Request checklist

  • Documentation: If this feature has or requires documentation, the relevant docs have been updated.
  • Changelog: This PR updates the changelog with any user-visible changes.
  • Tests: This PR includes thorough tests or an explanation of why it does not

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #2450 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2450      +/-   ##
==========================================
+ Coverage   69.61%   69.62%   +<.01%     
==========================================
  Files         223      223              
  Lines        5464     5465       +1     
  Branches      877      877              
==========================================
+ Hits         3804     3805       +1     
  Misses       1641     1641              
  Partials       19       19
Impacted Files Coverage Δ
...console/input/components/console-language-menu.jsx 73.33% <100%> (+1.9%) ⬆️

@wlach
Copy link
Contributor

wlach commented Nov 18, 2019

Looks great!

@wlach wlach merged commit 6f3d61d into iodide-project:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants