Use a custom escaping function instead of lodash for unescaping iomd #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlach
force-pushed
the
refined-escape-logic
branch
from
50c4f0f
to
8e52174
Compare
This fixes one edge case which should be very rare (where an unescaped sequence becomes an escape sequence after the lodash transformation)
wlach
force-pushed
the
refined-escape-logic
branch
from
8e52174
to
cc33680
Compare
|
I realized later today that my earlier solution could fail in an obscure edge case. No rush on looking at / merging this one, since I think that should be exceedingly rare. |
Codecov Report
@@ Coverage Diff @@
## master #2526 +/- ##
=========================================
+ Coverage 70.99% 71.09% +0.1%
=========================================
Files 239 238 -1
Lines 5874 5843 -31
Branches 938 935 -3
=========================================
- Hits 4170 4154 -16
+ Misses 1685 1670 -15
Partials 19 19
|
mdboom
approved these changes
Dec 9, 2019
This would let us catch issues like iodide-project#2524 due to Django upgrades in CI
wlach
force-pushed
the
refined-escape-logic
branch
from
32b392f
to
fc93f3f
Compare
|
As a last-minute addition, I changed the server-side unit test to expect a particular type of escaping, rather than just trusting the output of Django's escape function would be ok. This would have caught the original problem before we merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one edge case which should be very rare (where an
unescaped sequence becomes an escape sequence after the lodash
transformation)