-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make autocompetion language agnostic #2539
Conversation
Codecov Report
@@ Coverage Diff @@
## autocomplete #2539 +/- ##
=============================================
Coverage 71.17% 71.17%
=============================================
Files 239 239
Lines 5859 5859
Branches 937 937
=============================================
Hits 4170 4170
Misses 1670 1670
Partials 19 19
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow that was fast, i thought i'd handle the generalization once you took care of the pyodide side... this is great! :-D
expanded on the doc string a bit, other than that it all looks good!
6c41af4
to
ffbe649
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spotted one more small thing
code looks good @mdboom, thanks! one last thought: add a note in the changelog? have not tested this with pyodide of course, since that will depend on your deploy schedule, but merge this as soon as you wish! (and ping the channel when the relevant pyodide updates deploy! i'm excited about this one!) |
This is a follow on to #2535 that makes autocomplete work on any language with a language definition.
The primary change (beyond the obvious) is to send the entire code chunk up to the cursor across the wire to the eval frame and doing any language-specific parsing of it on that side. This is more language generic, since language plugins can't run code on the editor side.
To work with Python, will also require pyodide/pyodide#584 to be merged and released.
Pull Request checklist