Switch to JsDelivr CDN for pyodide 0.15.0 #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3020 +/- ##
=======================================
Coverage 72.82% 72.82%
=======================================
Files 247 247
Lines 6128 6128
Branches 994 994
=======================================
Hits 4463 4463
Misses 1646 1646
Partials 19 19
|
wlach
approved these changes
Mar 20, 2021
|
Sorry for the delay on this @rth. I think indeed using the older version here is what's desirable, I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to JsDelivr CDN while still using pyodide 0.15.0, in order to reduce usage of previous CDN endpoint.
The only thing I'm not sure about is whether iodide would set
windows.languagePluginUrltohttps://cdn.jsdelivr.net/v0.15.0/full/in this case before loadingpyodide.js. It does seem to be set here but I could be missing something. This is a requirement, otherwise packages will still be loaded from the previous CDN which is hardcoded inpyodide.js.It we update to pyodide 0.16.1, which should also be compatible with iodide, this should no longer be be an issue, though it includes Python 3.8 and updated packages so there is a slightly higher risk of it breaking something in existing notebooks.