hum it has been a while ... i sort of moved blockfinder to use a class style setup and optparser instead of getopt. This also has some more ipv6 functionality (iff IPy is available). #18
Conversation
…get the ipv6 addr of a host Signed-off-by: dave bl <db@d1b.org>
… which is pulled from 'test_data.py'. Run all the tests with verbosity=2 Signed-off-by: dave bl <db@d1b.org>
…y as the usage() method's, OptionParser (imho) makes for much cleaner code . Signed-off-by: dave bl <db@d1b.org>
Signed-off-by: dave bl <db@d1b.org>
Signed-off-by: dave bl <db@d1b.org>
…_use_ipv6 test case Signed-off-by: dave bl <db@d1b.org>
… declared Signed-off-by: dave bl <db@d1b.org>
…ad only 1024 bytes at a time. Signed-off-by: dave bl <db@d1b.org>
…tionality). Signed-off-by: dave bl <db@d1b.org>
…to use the cursor after calling this method an exception would be raised. This meant that ipv4 LIR lookups were broken. Signed-off-by: dave bl <db@d1b.org>
|
It is going to take me a bit to review this but overall, I plan to merge it pending review. |
|
you should also pull in d1b@518907e |
…"/test/" as the test_dir in BlockFinderTestExtras. Add a clean_up method to BlockFinderTestExtras to remove the temporary base folder when done. Signed-off-by: dave bl <db@d1b.org>
…on of lir rows - the process was taking a *very* long time. This 'commit' moves the commit() to come after rows have been inserted. Signed-off-by: dave bl <db@d1b.org>
…by one in some cases. This commit should fix that issue. Tests will be added for the issue in a later commit. Signed-off-by: dave bl <db@d1b.org>
…ould be listed incorrectly where a delegation listing specified more than one CIDR block (e.g. 193.9.29.0 with a size of 768 - contains a /23 and a /24). This commit should fix that issue iff you have the netaddr module installed. Signed-off-by: dave bl <db@d1b.org>
|
I'm going to review/merge these today or tomorrow - sorry for the giant delay. |
|
The README should specify where one can download NetAddr (http://code.google.com/p/netaddr/) and IPy (http://c0re.23.nu/c0de/IPy/) that are both imported. |
|
It's also worth noting 'python-ipy' and 'python-netaddr' are valid debian/ubuntu/etc package names. |
|
I've reviewed it all and merged everything - thanks! |
|
I've noticed this - I'm not sure if it's new: ./blockfinder -l Thoughts? |
|
@hellais yes that maybe the case now - but as python2.7 is the last python 2.X release (or will be). So using optparse is ok for python 2.X. We don't currently support python3 - when we add support for python3 we can review this. |
|
@ioerror iirc that was there before. It should probably only be shown in verbose mode.
|
hum it has been a while ... i sort of moved blockfinder to use a class style setup and optparser instead of getopt. This also has some more ipv6 functionality (iff IPy is available).