Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

Update README.md #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion supplychain/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,13 @@ SCRO.owl imports IOF Core directly. BFO-2020.owl and IOF-AnnotationVocabulary.rd
> click the image to view the enlarged image in a new tab
![Taxonomy of SCRO Continuants](images/SCRO-continuants.png)

### Taxonomy of SCRO Continuants
### Taxonomy of SCRO Occurrents
> click the image to view the enlarged image in a new tab
![Taxonomy of SCRO Continuants](images/SCRO-Occurrents.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't 'Taxonomy of SCRO Continuants' read here 'Taxonomy of SCRO Occurrents'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first image is Taxonomy of SCRO Continuants and the second image is Taxonomy of SCRO Occurrents

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant line 25 in README.md file:
![Taxonomy of SCRO Continuants](images/SCRO-Occurrents.png)
I think it should read:
![Taxonomy of SCRO Occurrents](images/SCRO-Occurrents.png)


## Glossary of Terms
[The glossary](https://htmlpreview.github.io/?https://github.com/InfoneerTXST/Glossary/blob/master/index.html) provides the natural language definitions of SCRO classes and properties

## Example RDF Dataset
This dataset represents a hypothetical supply chain as depicted in [this image](https://github.com/iofoundry/ontology/blob/master/supplychain/Documentation%20&%20Resources/Terms-Patterns-Modules/Ford%20Supply%20Chain.md). The RDF dataset demonstrates how the class "Supply Chain Relationship' is used to represent the strucrue of a supply chain.
- [RDF Dataset](https://github.com/iofoundry/ontology/blob/master/supplychain/data/SCRO_Ford.tt)
Copy link
Contributor

@kbserm kbserm Jan 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fameri Going forward, I think you want to put all the artifacts, including the glossary of terms and RDF Dataset, in the repo as much as possible so that are properly versioned along with the ontology.

Also, not sure why I can't add comments to the rest of the text below. there are typos that should be fixed to "Once the general......" and I think better replace the word 're-architectured' with 're-modularized'.

Expand Down