Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Sentry Extension Public for Kotlin DSL Compatibility #118

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

vlh-ioki
Copy link
Collaborator

This pull request addresses the visibility issue of the Sentry Extension when using Kotlin DSL. Previously, the extension was not accessible in Kotlin DSL due to its visibility constraints.

Changes include:

  1. Updated the Sentry Extension to be public, allowing it to be accessed and utilized in Kotlin DSL scripts.
  2. Refactored the existing Groovy DSL scripts to Kotlin DSL for consistency and to ensure compatibility with the updated Sentry Extension.
  3. Updated the test cases to reflect the changes and ensure that the updated Sentry Extension works as expected with Kotlin DSL.

These changes will improve the plugin's compatibility with Kotlin DSL and provide a more flexible and consistent configuration experience for users.

@vlh-ioki vlh-ioki requested a review from StefMa June 20, 2024 11:49
@vlh-ioki vlh-ioki changed the title Title: Make Sentry Extension Public for Kotlin DSL Compatibility Make Sentry Extension Public for Kotlin DSL Compatibility Jun 20, 2024
Copy link
Collaborator

@StefMa StefMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice hit!
Thank you very much!

Please drop the increase version commit.
This shouldn't be here 🙃 .

Rest looks good 👏

androidTestProject/build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
@vlh-ioki vlh-ioki merged commit 8e1c794 into main Jun 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants