Client create collection via http client #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsjethani
requested changes
Jul 19, 2023
StefMa
force-pushed
the
client-create-collection
branch
from
c9525a2
to
f4b8020
Compare
|
@rsjethani can you please have another look on this so I can continue with the CLI 🙏 🙂 |
rsjethani
force-pushed
the
client-create-collection
branch
from
f4b8020
to
e897b01
Compare
rsjethani
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not fix anything, but is somewhat part of #14
This adds the support for the HTTP client to create a collection.
https://www.getoutline.com/developers#tag/Collections/paths/~1collections.create/post
Only "name" is required, so I added it.
We can later adjust it. Not sure (yet) what the default value for
privateis.I assume it is
true, but if not, we should add it to the request and make it later configurable.I also fixed a few typos suggested by my IDE :)