Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type attribute for Platform::Area #28

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Use type attribute for Platform::Area #28

merged 1 commit into from
Nov 10, 2021

Conversation

A5308Y
Copy link
Collaborator

@A5308Y A5308Y commented Nov 10, 2021 •
edited

Note that we need to inherit from Ioki::Model::Base instead of Ioki::Model::Platform::Base because the latter already defines type.

@rmehner rmehner merged commit ea3b92d into master Nov 10, 2021
@rmehner rmehner deleted the fix-area branch November 10, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmehner rmehner rmehner approved these changes

@ans-ioki ans-ioki Awaiting requested review from ans-ioki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@A5308Y @rmehner