-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing platform models and attributes #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A5308Y
force-pushed
the
platform-model-api-completeness
branch
from
November 25, 2021 07:36
f597352
to
d7f7da7
Compare
A5308Y
force-pushed
the
platform-model-api-completeness
branch
from
November 29, 2021 11:44
b769653
to
581c7b6
Compare
A5308Y
force-pushed
the
platform-model-api-completeness
branch
2 times, most recently
from
December 1, 2021 07:48
cdda919
to
5daf628
Compare
A5308Y
force-pushed
the
platform-model-api-completeness
branch
from
December 15, 2021 10:30
d8e5686
to
f8f89ab
Compare
A5308Y
force-pushed
the
platform-model-api-completeness
branch
from
December 15, 2021 10:38
f8f89ab
to
2aa32b2
Compare
A5308Y
force-pushed
the
platform-model-api-completeness
branch
from
December 15, 2021 10:51
52dcde7
to
85bf212
Compare
rmehner
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Would be nice to get that in a release soon, so I can consume it to make the form dynamic.
Going forward I'd suggest to add smaller PRs on top of this (says the person who previously opened up a massive PR ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos
unspecified_models
inopenapi_spec.rb
tounvalidated
on the model.Ioki::Model::Platform
all the timespecification_scope
andschema_path
from the model instead of passing it on.def self.specification_scope; nil; end
unvalidated
and maybe find a better name.Edit:
This is meant as a quick fix so @rmehner and @eikes don't have to wait even longer. See #52 for a follow-up issue.