Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing platform models and attributes #43

Merged
merged 17 commits into from
Dec 16, 2021

Conversation

A5308Y
Copy link
Collaborator

@A5308Y A5308Y commented Nov 24, 2021

Todos

  • Support all GET-paths of the platform API so schaufel can use all the new models for the dashboard.
  • Transform unspecified_models in openapi_spec.rb to unvalidated on the model.
  • Try to avoid calling Ioki::Model::Platform all the time
  • Reenable all model checks and find a way to only check for validity and not completeness (passenger, driver) for now. It's probably best to fix all existing models and not add the other models for now so we have missing models but not partially supported models. That way it's more obvious if something is not supported yet.
  • Read specification_scope and schema_path from the model instead of passing it on.
  • Find a way not to have to write: def self.specification_scope; nil; end
  • Require all models in ioki-model
  • Explain/document unvalidated and maybe find a better name.
  • Check what happens for dependent "object"-attributes when the model_class is omitted. -> It'll be a Hash.
  • Manually check that all unvalidated models inherit from the correct base class.
  • Ensure all date_time objects are date_time
  • Rubocop

Edit:
This is meant as a quick fix so @rmehner and @eikes don't have to wait even longer. See #52 for a follow-up issue.

@A5308Y A5308Y force-pushed the platform-model-api-completeness branch from f597352 to d7f7da7 Compare November 25, 2021 07:36
@A5308Y A5308Y self-assigned this Nov 25, 2021
@A5308Y A5308Y force-pushed the platform-model-api-completeness branch from b769653 to 581c7b6 Compare November 29, 2021 11:44
@A5308Y A5308Y force-pushed the platform-model-api-completeness branch 2 times, most recently from cdda919 to 5daf628 Compare December 1, 2021 07:48
@A5308Y A5308Y force-pushed the platform-model-api-completeness branch from d8e5686 to f8f89ab Compare December 15, 2021 10:30
@A5308Y A5308Y marked this pull request as ready for review December 15, 2021 10:31
@A5308Y A5308Y mentioned this pull request Dec 15, 2021
5 tasks
@A5308Y A5308Y force-pushed the platform-model-api-completeness branch from f8f89ab to 2aa32b2 Compare December 15, 2021 10:38
Copy link
Collaborator

@rmehner rmehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would be nice to get that in a release soon, so I can consume it to make the form dynamic.

Going forward I'd suggest to add smaller PRs on top of this (says the person who previously opened up a massive PR ...)

@A5308Y A5308Y merged commit d7d4595 into master Dec 16, 2021
@A5308Y A5308Y deleted the platform-model-api-completeness branch December 16, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants