Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence warning in specs #61

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Silence warning in specs #61

merged 1 commit into from
Jan 26, 2022

Conversation

A5308Y
Copy link
Collaborator

@A5308Y A5308Y commented Jan 26, 2022

No description provided.

@A5308Y
Copy link
Collaborator Author

A5308Y commented Jan 26, 2022

remove_const is a private method so public_send is not an option. This thread suggests 2 other ways of disabling the warning for our case, but I found send in specs acceptable and a little less work to understand.

@A5308Y A5308Y requested a review from eikes January 26, 2022 07:20
eikes
eikes approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@eikes eikes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@A5308Y A5308Y merged commit 2d8a51d into master Jan 26, 2022
@A5308Y A5308Y deleted the silence-warning branch January 26, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikes eikes eikes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@A5308Y @eikes