Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2e/storage): support StorageClass Secrets E2E test in CSI #2

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

gxglls
Copy link
Collaborator

@gxglls gxglls commented Aug 5, 2021

后续的 case 单独 pr 提交

// https://kubernetes-csi.github.io/docs/secrets-and-credentials-storage-class.html
type CSIStorageClassAuthParamKey string

// const AuthParamKeyPrefix = "csi.storage.k8s.io/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this?

test/e2e/storage/testsuites/auth.go Show resolved Hide resolved
test/e2e/storage/testsuites/auth.go Show resolved Hide resolved
Copy link

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylezh kylezh merged commit c3707bd into release-1.21 Aug 6, 2021
@kylezh kylezh deleted the e2e-auth branch August 6, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants