Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched IV vector to openssl and added a test to verify it works as before #4

Merged
merged 2 commits into from
Sep 14, 2017
Merged

Switched IV vector to openssl and added a test to verify it works as before #4

merged 2 commits into from
Sep 14, 2017

Conversation

NoMan2000
Copy link
Contributor

Added a quick unit test to verify that everything works and updated it to only use openssl.

@NoMan2000
Update cryptor.php
83b6668
@NoMan2000
Simple Assert test
492d280 
Added a simple assert test to prove it works.

Signed-off-by: Michael Soileau <webart.video@gmail.com>
@NoMan2000 NoMan2000 mentioned this pull request Dec 2, 2016
Closed
@cstanke
Copy link

cstanke commented Dec 20, 2016

Great PR! Thanks. I hope this gets merged into master, otherwise I'll keep using NoMan2000's fork.

nickion
nickion requested changes Dec 20, 2016
View reviewed changes
Copy link
Contributor

@nickion nickion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. The change is good, however for consistency and quality, please make a change to follow the same convention for the Exception message as with the others.

@dianjuar
Copy link

dianjuar commented Aug 27, 2017 •
edited
Loading

This is a great PR!

I can use this PR on my php7.1 because mcrypt has been deprecated on php7.1

@nickion could you please suggest how the messages need to look like?
Is a shame that this super awesome PR can not be accepted for a simple message style

@bfentiman
Copy link

Thanks for the pull request, sorry it took us a while to merge it

@bfentiman bfentiman merged commit ade46cb into ioncube:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickion nickion nickion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NoMan2000 @cstanke @dianjuar @bfentiman @nickion