-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added slowlog, pipelining, cpu utilization estimates and memory usage estimates per database #7
Conversation
Thanks for the changes ! Haven't got a change to try them out yet but I wonder about two things:
|
I hope the changes to redis-py will be merged soon, but I haven't gotten a reply on that. You are right about the templates, I will have to exclude those from the commit, I'll branch this change and revert that part :) |
Should I keep this pull request open or is this completely obsolete? Can't say I have been using Redisboard myself lately so if it won't be merged as is I'd rather close it. No time to rewrite and test it. |
Hmmm... lemme take a look again :) Did you get those changes to redis-py merged ? I can't seem to find your PR |
Hard to say, my pull request over there never got merged and I'm not sure if it got implemented some other way. I'll just close this one as well, I'm just doing some spring cleaning in my list of pull requests. No point in waiting for things that will never happen ;) |
Well it would be a shame to close it just because redis-py's maintainer forgot to merge your PR ... Sometimes you need to insist :) |
I guess you're right, I've reopened and I'll see if it ever gets there. Just don't have much hope after 2-3 years ;) |
2 years have passed 😁 Looks like the SLOWLOG was merged in redis-py. I have rebased your changes in https://github.com/ionelmc/django-redisboard/tree/develop |
Awesome, thanks :D |
No description provided.