Skip to content

Added slowlog, pipelining, cpu utilization estimates and memory usage estimates per database #7

Closed
wants to merge 13 commits into from

2 participants

@WoLpH
WoLpH commented Apr 16, 2012

No description provided.

@ionelmc
Owner
ionelmc commented Apr 16, 2012

Thanks for the changes ! Haven't got a change to try them out yet but I wonder about two things:

  • the template media url changes won't work on 1.4 or 1.3 - were you using a pre-final 1.3 version or I remember incorrectly?
  • those changes to redis-py will be merged no ?
@WoLpH
WoLpH commented Apr 16, 2012

I hope the changes to redis-py will be merged soon, but I haven't gotten a reply on that.
If the slowlog doesn't work it will just not show anything, so it's not that much of a problem I think, but I'd have to test that.

You are right about the templates, I will have to exclude those from the commit, I'll branch this change and revert that part :)

@WoLpH
WoLpH commented Feb 20, 2014

Should I keep this pull request open or is this completely obsolete? Can't say I have been using Redisboard myself lately so if it won't be merged as is I'd rather close it.

No time to rewrite and test it.

@ionelmc
Owner
ionelmc commented Feb 20, 2014

Hmmm... lemme take a look again :)

Did you get those changes to redis-py merged ? I can't seem to find your PR

@WoLpH
WoLpH commented Feb 20, 2014

Hard to say, my pull request over there never got merged and I'm not sure if it got implemented some other way.
Here's the pull request: andymccurdy/redis-py#170

I'll just close this one as well, I'm just doing some spring cleaning in my list of pull requests. No point in waiting for things that will never happen ;)

@WoLpH WoLpH closed this Feb 20, 2014
@ionelmc
Owner
ionelmc commented Feb 20, 2014

Well it would be a shame to close it just because redis-py's maintainer forgot to merge your PR ...

Sometimes you need to insist :)

@WoLpH
WoLpH commented Feb 20, 2014

I guess you're right, I've reopened and I'll see if it ever gets there.

Just don't have much hope after 2-3 years ;)

@WoLpH WoLpH reopened this Feb 20, 2014
@ionelmc
Owner
ionelmc commented Dec 9, 2014

2 years have passed :grin:

Looks like the SLOWLOG was merged in redis-py.

I have rebased your changes in https://github.com/ionelmc/django-redisboard/tree/develop

@ionelmc ionelmc closed this Dec 9, 2014
@WoLpH
WoLpH commented Dec 9, 2014

Awesome, thanks :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.